Refactor Installer and Host Tests to Pester 4 Syntax - #6283
Closed
Ilya (iSazonov) wants to merge 9 commits into
Closed
Refactor Installer and Host Tests to Pester 4 Syntax#6283Ilya (iSazonov) wants to merge 9 commits into
Ilya (iSazonov) wants to merge 9 commits into
Conversation
Ilya (iSazonov)
requested review from
Aditya Patwardhan (adityapatwardhan) and
Klaudia Algiz (kalgiz)
March 1, 2018 17:12
20 tasks
Aditya Patwardhan (adityapatwardhan)
requested changes
Mar 1, 2018
| } | ||
|
|
||
| It "-File should be able to pass bool string values as string to parameters: <BoolString>" -TestCases @( | ||
| It "-File Should -Be able to pass bool string values as string to parameters: <BoolString>" -TestCases @( |
There was a problem hiding this comment.
It seems this was unintentional
| } | ||
|
|
||
| It "-File should be able to pass bool string values as string to positional parameters: <BoolString>" -TestCases @( | ||
| It "-File Should -Be able to pass bool string values as string to positional parameters: <BoolString>" -TestCases @( |
There was a problem hiding this comment.
It seems this was unintentional
| } | ||
|
|
||
| It "-File should be able to pass bool string values as bool to switches: <BoolString>" -TestCases @( | ||
| It "-File Should -Be able to pass bool string values as bool to switches: <BoolString>" -TestCases @( |
There was a problem hiding this comment.
It seems this was unintentional
| # ensure the setting was written to the settings file. | ||
| $content = (Get-Content -Path $CustomSettingsFile | ConvertFrom-Json) | ||
| $content.'Microsoft.PowerShell:ExecutionPolicy' | Should Be $expectedValue | ||
| $content.'Microsoft.PowerShell:ExecutionPolicy' | Should -Be $expectedValue |
There was a problem hiding this comment.
This should be -BeExactly
| # ensure the setting is applied on next run | ||
| $actualValue = & $powershell -NoProfile -SettingsFile $CustomSettingsFile -Command {(Get-ExecutionPolicy -Scope LocalMachine).ToString()} | ||
| $actualValue | Should Be $expectedValue | ||
| $actualValue | Should -Be $expectedValue |
There was a problem hiding this comment.
This should be -BeExactly
| $result.CompletionMatches[0].CompletionText | Should Be $DatetimeProperties[0].Name # Date | ||
| $result.CompletionMatches[1].CompletionText | Should Be $DatetimeProperties[1].Name # DateTime | ||
| $result.CompletionMatches.Count | Should -Be $DatetimeProperties.Count | ||
| $result.CompletionMatches[0].CompletionText | Should -Be $DatetimeProperties[0].Name # Date |
There was a problem hiding this comment.
Should be -BeExactly
| $result.CompletionMatches[1].CompletionText | Should Be $DatetimeProperties[1].Name # DateTime | ||
| $result.CompletionMatches.Count | Should -Be $DatetimeProperties.Count | ||
| $result.CompletionMatches[0].CompletionText | Should -Be $DatetimeProperties[0].Name # Date | ||
| $result.CompletionMatches[1].CompletionText | Should -Be $DatetimeProperties[1].Name # DateTime |
There was a problem hiding this comment.
Should be -BeExactly
| } | ||
|
|
||
| $result | Should Not Be $null | ||
| $result | Should -Not -Be $null |
There was a problem hiding this comment.
Should be -Not -BeNullOrEmpty
Collaborator
Author
There was a problem hiding this comment.
Mark Kraus (@markekraus) Can you confirm using -BeNullOrEmpty?
| $result.CompletionMatches.Count | Should -Be 3 | ||
| $result.CompletionMatches[0].CompletionText | Should -Be 'Expression' | ||
| $result.CompletionMatches[1].CompletionText | Should -Be 'Ascending' | ||
| $result.CompletionMatches[2].CompletionText | Should -Be 'Descending' |
There was a problem hiding this comment.
Similar to above comments.
| It 'Should complete Command' { | ||
| $res = TabExpansion2 -inputScript 'Get-Com' -cursorColumn 'Get-Com'.Length | ||
| $res.CompletionMatches[0].CompletionText | Should be Get-Command | ||
| $res.CompletionMatches[0].CompletionText | Should -Be Get-Command |
There was a problem hiding this comment.
All Shoulds comparing string must be -BeExactly
Collaborator
Author
There was a problem hiding this comment.
I believe we shouldn't mess syntax changes and the functional changes - our tests have tons gaps like this - this huge job needs to be done in other PRs.
Collaborator
Author
|
Done in #6250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #6245
Changes from Should Be syntax to Should -Be syntax.
One commit per file.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests