Change packaging to differentiate only between major versions and previews - #6968
Merged
Travis Plunk (TravisEz13) merged 5 commits intoJun 5, 2018
Merged
Conversation
Rob Holt (rjmholt)
requested review from
Travis Plunk (TravisEz13),
Dongbo Wang (daxian-dbw) and
Joey Aiello (joeyaiello)
May 31, 2018 18:18
Rob Holt (rjmholt)
requested a review
from Aditya Patwardhan (adityapatwardhan)
as a code owner
May 31, 2018 18:18
Collaborator
|
Seems typo in PR description "Preview releases are named powershell-release" -> "◦Preview releases are named powershell-preview". |
Contributor
|
I don't want to convolute this PR but I would like to gently remind that implementing isssue #6317 would be useful for people using previews. Personally, I mostly use only either the RTM or the daily build. |
| $Suffix = $packageVersion | ||
| } | ||
| # Break the version down into its components, we are interested in the major version | ||
| $VersionMatch = [regex]::Match($Version, '(\d+)(?:.(\d+)(?:.(\d+)(?:-preview(?:.(\d+))?)?)?)?') |
There was a problem hiding this comment.
nit: use PowerShell syntax
Travis Plunk (TravisEz13)
approved these changes
Jun 5, 2018
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
With minor comment
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
…views (PowerShell#6968) Change the *nix packaging over with the following changes: Package name (as used by e.g. apt): Non-preview releases are namedpowershell Preview releases are named powershell-preview Installation path: No longer looks like /opt/microsoft/powershell/6.1.0/ or /opt/microsoft/powershell/6.1.0-preview.1/ Non-previews go to a path like /opt/microsoft/powershell/6/ Previews go to a path like /opt/microsoft/powershell/6-preview/ Path to executable symlink: Allows SxS with preview Non-previews linked to /usr/bin/pwsh or /usr/local/bin/pwsh on macOS Previews linked to /usr/bin/pwsh-preview or /usr/local/bin/pwsh-preview on macOS Implements PowerShell/PowerShell-RFC#115 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is breaking as it changes the symbolic links used to run PowerShell from preview builds to
* Previews linked to
/usr/bin/pwsh-previewon linux and/usr/local/bin/pwsh-previewon macOSChange the *nix packaging over with the following changes:
apt):powershellpowershell-preview/opt/microsoft/powershell/6.1.0/or/opt/microsoft/powershell/6.1.0-preview.1//opt/microsoft/powershell/6//opt/microsoft/powershell/6-preview//usr/bin/pwshor/usr/local/bin/pwshon macOS/usr/bin/pwsh-previewor/usr/local/bin/pwsh-previewon macOSImplements PowerShell/PowerShell-RFC#115 (comment)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests