Remove SemanticVersion from list of KnownTypes for serialization - #7016
Conversation
|
It seems to be not in line with the PowerShell Committee's conclusion in #6448. |
|
Ilya (@iSazonov) you are correct, that committee decision was based on an incorrect hypothesis. |
Dongbo Wang (daxian-dbw)
left a comment
There was a problem hiding this comment.
LGTM. This is probably the cleanest way to deal with this issue 🎉
|
Strike my previous comment. It will be deserailzied to a |
|
Given it will come back as |
|
@PowerShell/powershell-committee reviewed this and agree this is approach |
Paul Higinbotham (PaulHigin)
left a comment
There was a problem hiding this comment.
I agree that this is the right change.
… to enable interop between WinPS and PSCore (PowerShell#7016) PowerShell serialization has a list of known PowerShell types. When an object is deserialized containing a known type it tries to deserialize the object to that specific type and throws an exception if it can't succeed. SemanticVersion only exists in PSCore6 so when remoting from Windows PowerShell or importing clixml generated from PSCore6 that contains SemanticVersion, it fails. With this fix, it will be rehydrated as a "PSObject" with "Deseriealized.System.Management.Automation.SemanticVersion" in the 'TypeNames' in both Windows PowerShell and PowerShell Core.
PR Summary
PowerShell serialization has a list of known PowerShell types. When an object is deserialized containing a known type it tries to deserialize the object to that specific type and throws exception if it can't succeed. SemanticVersion only exists in PSCore6 so when remoting from Windows PowerShell or importing clixml generated from PSCore6 that contains SemanticVersion, it fails.
Fix #6448
Fix #1819
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests