Make -settingfile work for scriptblock logging on windows - #7631
Merged
Travis Plunk (TravisEz13) merged 6 commits intoAug 26, 2018
Merged
Conversation
Travis Plunk (TravisEz13)
requested review from
Aditya Patwardhan (adityapatwardhan),
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
August 24, 2018 21:41
Dan Travison (dantraMSFT)
approved these changes
Aug 24, 2018
| $values['LogLevel'] = $LogLevel.ToString() | ||
| } | ||
|
|
||
| if($IsWindows) |
Contributor
There was a problem hiding this comment.
Does this need to be conditional?
Member
Author
There was a problem hiding this comment.
The setting is only valid on windows
Travis Plunk (TravisEz13)
deleted the
fix_scriptblock_logging_on_windows
branch
August 26, 2018 18:03
14 tasks
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
…ll#7631) Make `-settingfile` work for scriptblock logging on windows - Move EarlyParse to the first thing in the ManagedEntrance so that we don't cache the settings before we parse the settings file. - Added a test case to prevent regression - I'm working on more test cases. Therefore, I used the TestCases parameter. - Changed the macOS tests back to CI as I think they are stable enough now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make
-settingfilework for scriptblock logging on windowsPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests