Revert error packet parsing changes - #508
Merged
Merged
Conversation
Contributor
Author
|
PS. working on the py26 and py3 cases now - fixed. |
| class TestRaiseException(TestCase): | ||
|
|
||
| def test_raise_mysql_exception(self): | ||
| data = "\xff\x15\x04Access denied" |
Contributor
Author
There was a problem hiding this comment.
Yup ;) On it, silly me.
Revert the changes made in commit 02910b7 to the mysql error packet parsing, as it didn't take the CLIENT_PROTOCOL_41 case into account. It appears that the non-CLIENT_PROTOCOL_41 case was off by one as well (sliced data on 4 vs 3). I also added two new tests to cover those cases. See: https://dev.mysql.com/doc/internals/en/packet-ERR_Packet.html
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for issue #507.
Revert the changes made in commit 02910b7 to the mysql error packet
parsing, as it didn't take the CLIENT_PROTOCOL_41 case into account.
It appears that the non-CLIENT_PROTOCOL_41 case was off by one as well
(sliced data on 4 vs 3).
I also added two new tests to cover those cases.
See: https://dev.mysql.com/doc/internals/en/packet-ERR_Packet.html