Set python_requires='>=3.6' - #936
Merged
Merged
Conversation
Nicusor97
force-pushed
the
add_python_requires
branch
from
January 7, 2021 07:54
d74b819 to
b3c2acb
Compare
|
can a new release also be pushed on pypi including this fix so it install fine on python2 as well? |
Contributor
Author
|
I think the 1.0.0 version needs to be yanked too in order to avoid python2 user to install this version. |
Member
|
I will do it someday in this year. |
Member
|
But note that you can see such issue always when you are using Python 2.7. I strongly recommend to move Python 3. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From your changelog seems like in the latest version you dropped Python 2 support but it is incomplete. You need to set python_requires in your setup.py that will prevent users with Python 2.7 from downloading a sdist version they cannot build.
Note: supporting python_requires requires setuptools>=24.2.0 and pip>=9.0.0 to benefit from it.
Details here: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
Here is the current issue if you try to install latest version of fastavro on Python 2:
Also, the 1.0.0 version could be yanked.