[pull] main from cloudflare:main#209
Merged
Merged
Conversation
When using persistent stubs, it turns out that a stub produced by `ctx.restore()` holds a self-reference which can lead to a cyclic self-cancellation issue when tearing down the IoContext. We were deferring destruction of the worker, but not unlink(). We need to defer both.
If any externals are present, clearExternalsIfPresent() will execute a new query which causes the previous `query.changeCount()` to return the wrong value, because the change count comes from a SQLite API that reports from whatever query ran last. Arguably, the `changeCount()` method is a bad interface but I've left fixing it as a TODO.
Fix two bugs affecting persistent stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )