Skip to content

[pull] main from cloudflare:main#209

Merged
pull[bot] merged 6 commits into
Reality2byte:mainfrom
cloudflare:main
Jun 23, 2026
Merged

[pull] main from cloudflare:main#209
pull[bot] merged 6 commits into
Reality2byte:mainfrom
cloudflare:main

Conversation

@pull

@pull pull Bot commented Jun 23, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

workers-devprod and others added 6 commits June 21, 2026 01:35
When using persistent stubs, it turns out that a stub produced by `ctx.restore()` holds a self-reference which can lead to a cyclic self-cancellation issue when tearing down the IoContext. We were deferring destruction of the worker, but not unlink(). We need to defer both.
If any externals are present, clearExternalsIfPresent() will execute a new query which causes the previous `query.changeCount()` to return the wrong value, because the change count comes from a SQLite API that reports from whatever query ran last.

Arguably, the `changeCount()` method is a bad interface but I've left fixing it as a TODO.
@pull pull Bot locked and limited conversation to collaborators Jun 23, 2026
@pull pull Bot added the ⤵️ pull label Jun 23, 2026
@pull pull Bot merged commit b32fe61 into Reality2byte:main Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants