Skip to content

BUG: Remove duplicate controller process#949

Merged
MateusStano merged 2 commits into
RocketPy-Team:developfrom
zuorenchen:bug/DuplicateControllerProcess
Apr 4, 2026
Merged

BUG: Remove duplicate controller process#949
MateusStano merged 2 commits into
RocketPy-Team:developfrom
zuorenchen:bug/DuplicateControllerProcess

Conversation

@zuorenchen

@zuorenchen zuorenchen commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

#948 BUG: Controller processed twice in flight.py

New behavior

  1. Remove duplicate process
  2. Fix the condition for sensor measurement. Should check if the sensor exists in the time_node instead of flight.sensor

Breaking change

  • No

Additional information

image image

@zuorenchen zuorenchen requested a review from a team as a code owner April 4, 2026 10:43
@codecov

codecov Bot commented Apr 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.05%. Comparing base (9cf3dd4) to head (b23ab58).
⚠️ Report is 50 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #949      +/-   ##
===========================================
+ Coverage    80.27%   81.05%   +0.78%     
===========================================
  Files          104      107       +3     
  Lines        12769    13903    +1134     
===========================================
+ Hits         10250    11269    +1019     
- Misses        2519     2634     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MateusStano MateusStano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch!

@MateusStano MateusStano added Bug Something isn't working Controllers Controlling rocket flight methods labels Apr 4, 2026
@MateusStano MateusStano merged commit de29100 into RocketPy-Team:develop Apr 4, 2026
10 checks passed
@zuorenchen zuorenchen deleted the bug/DuplicateControllerProcess branch April 5, 2026 03:02
Gui-FernandesBR added a commit that referenced this pull request Jul 4, 2026
* MNT: final fixes before next release

Documentation, CHANGELOG and test polish ahead of the next release
(v1.13.0), covering PRs merged since v1.12.0.

CHANGELOG
- Add missing entries: Individual Fins (#818), AIGFS/HRRR forecast
  models (#951), duplicate-controller fix (#949), Valkyrie flight
  example (#967).
- Hygiene: de-duplicate #958/#966, move #974 to Fixed and #1041 to
  Removed only, drop the already-released #914 duplicate, and point the
  logging (#973) and ND-interp (#969) entries at their PRs.
- Backfill #940/#941/#944 (shipped in v1.12.0 code but never logged)
  under the [v1.12.0] section.

Docs
- New exceptions reference page (rocketpy.exceptions) wired into the
  reference index; note UnstableRocketWarning in the rocket stability
  docs (#970).
- tanks.rst: switch examples to radius_function= and add a deprecation
  note (#957).
- forecast.rst: fix the HRRR example (missing code directive + stray
  sentence) (#951).
- airbrakes.rst: document discrete vs continuous controllers
  (sampling_rate=None) (#946).
- rocket_usage.rst: note that Parachute is now an abstract base;
  instantiate HemisphericalParachute (#958).

Tests
- New regression tests: 3D ND-interp NaN outside convex hull (#969),
  abstract Parachute cannot be instantiated (#958), Monte Carlo
  convergence stopping (#922), EnvironmentAnalysis surviving wind API
  (#1041), radial-burn grain geometry over time (#944), RingClusterMotor
  full flight (#924), discrete controller invoked once per node (#949),
  acceleration-based parachute trigger deploys (#911).
- Backfill regression tests for ThrustCurve API timeouts (#940) and
  power_off/on_drag Function objects + _input attributes (#941).


* make format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Controllers Controlling rocket flight methods

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants