Skip to content

Tuned hit finder parameters#912

Open
mattiasotgia wants to merge 1 commit into
developfrom
feature/msotgia_new_hitfinder_training
Open

Tuned hit finder parameters#912
mattiasotgia wants to merge 1 commit into
developfrom
feature/msotgia_new_hitfinder_training

Conversation

@mattiasotgia

Copy link
Copy Markdown

This PR introduces the updated hit finder parameters values obtained after the latest tuning.

Details can be found in the latest presentation given at the sim/reco ICARUS WG meeting, found on docdb-48139.

Description

This refactor the dependencies of the hit finder module across the FHiCL in stage1, removing the outdated sbn default and introducing the ICARUS-tailored version.

In hitfindermodules_icarus.fcl the updated parameter values are set, and the NextADCThreshold parameter value is introduced for the candidate hit finder module.

Depends on

This PR has been done as part of an infrastructure-wide attempt of freezing the code up to a certain version. The following is a list of (both closed/merged and open) PR that have been included as part of the validation studies.

Additionally, it requires the following to be merged to address some issues that we've been seeing on shower like topologies

This will also require develop to be on the same page as release/SBN2025A since this was cut starting from there, but

Asking @acampani, @cerati and @SFBayLaser for a review.

@mattiasotgia mattiasotgia self-assigned this Jul 10, 2026
@mattiasotgia mattiasotgia added the enhancement New feature or request label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant