Skip to content

fix transition not working - #248

Closed
wishWinds wants to merge 2 commits into
SDWebImage:masterfrom
wishWinds:wishWinds
Closed

fix transition not working#248
wishWinds wants to merge 2 commits into
SDWebImage:masterfrom
wishWinds:wishWinds

Conversation

@wishWinds

Copy link
Copy Markdown

This will fix transition modifier not working.
The side effect is transition will always animate even if image is load from memory or disk cache.

@dreampiggy

Copy link
Copy Markdown
Collaborator

I don't think add this into a ObservedObject is suitable...

The correct way maybe put this withAnimation into the WebImage's return body of images

@wishWinds

Copy link
Copy Markdown
Author

It may has no way to trigger animation within onSuccess callback. the imageManager are internal. and exposing the manager is not a good choice.
What I'm thinking is give a chance to tell the framework using animation when remote image Is come.
I'm thinking add a enableAnimation modifier to WebImage.
If you think this may be a right approach. I will make a new PR!

Thanks.

@zizooom

zizooom commented Dec 18, 2022

Copy link
Copy Markdown

Thank you

@Ziv-Nergal

Copy link
Copy Markdown

Any updates on this?
Still not working for me

@aviwad

aviwad commented Jul 29, 2023

Copy link
Copy Markdown

any update? transition still broken

@alexfanatics

Copy link
Copy Markdown

I found a workaround here: #272

@wishWinds wishWinds closed this Aug 13, 2023
@wishWinds
wishWinds deleted the wishWinds branch August 13, 2023 16:50
@aviwad

aviwad commented Aug 13, 2023

Copy link
Copy Markdown

why did you close the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants