Skip to content

Use the new way for AnimatedImageViewWrapper, fix the transition visual jump between placeholderImage and final image - #325

Closed
dreampiggy wants to merge 3 commits into
masterfrom
bugfix/transition
Closed

Use the new way for AnimatedImageViewWrapper, fix the transition visual jump between placeholderImage and final image#325
dreampiggy wants to merge 3 commits into
masterfrom
bugfix/transition

Conversation

@dreampiggy

Copy link
Copy Markdown
Collaborator

This close the issue during the changes of #324

@dreampiggy dreampiggy added the animated image AnimatedImage struct label Jul 1, 2024
@dreampiggy dreampiggy added the API API changes label Jul 1, 2024
@dreampiggy

Copy link
Copy Markdown
Collaborator Author

The private API wrapped is exposed by accident. So I'd decide to remove this. People who previouslly use onViewCreateBlock does not get effected

@dreampiggy

dreampiggy commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

Found serious regression on macOS. That _NSImageViewSimpleImageView no longer exists and cause SDAnimatedImageView animation buggy.

Close for now and use another workaround

@dreampiggy dreampiggy closed this Jul 1, 2024
@dreampiggy

dreampiggy commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator Author

image

compared to previous version:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

animated image AnimatedImage struct API API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant