@W-19364102 - Cart pick up section changes in StoreDisplay component to match figma - #3248
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
e7699e2 to
cbc7606
Compare
patricksullivansf
left a comment
There was a problem hiding this comment.
This much prettier and much more modular. A few must haves
- find a way to include phone & email in the new layout. remember the source figma was under-spec'd. but we still need these.
- strongly consider not having two desktop layouts. it adds code bloat and complexity and there is little advantage to the shopper. the places you need to align layout are: store locator modal, store locator page, cart, checkout, confirmation. use a similar layout throughout.
|
Hi @patricksullivansf , I've updated the PR with the latest code changes, test updates, and an updated description, including screenshots of the new layout we aligned on during the UX session with Felipe. |
shauryemahajanSF
left a comment
There was a problem hiding this comment.
LGTM, personally prefer the old UX I think its cleaner, but I know we talked w Felipe on this. If you can, send him the screenshots of before and after to just to make sure we're aligned.
patricksullivansf
left a comment
There was a problem hiding this comment.
Love the layout! made some minor comments. most importantly though please update the change log. Thank you!
| }) | ||
|
|
||
| test('does not render Change Store button when store has no name', () => { | ||
| test('still renders Change Store button when store has no name (callback provided)', () => { |
There was a problem hiding this comment.
this seems like a regression. Don't think it will actually happen so the original test is weird. but that said, allowing a shopper to choose a store without a name will mess up a lot of BOPIS UX.
There was a problem hiding this comment.
Absolutely right, I updated the test and updated the code to only show that button if the store has a name. Thanks!
| "defaultMessage": "{city}, {stateCode} {postalCode}" | ||
| }, | ||
| "store_display.label.store_contact_info": { | ||
| "defaultMessage": "Store Contact Info" |
b02a464
Description
This PR updates the pickup in store section on the cart page to closely resemble the designs. This also ensures layout similarity between the following pages:
Also this change refactors and cleans up code, which ensures there is no code duplication and the code is re-used where required.
Cart Page
Updated (without store distance/unit data available):
Updated (when store distance/unit data is available):
Store Locator Modal
Updated
Store Locator Page
Updated
Checkout Page
Updated (without store distance/unit data available):
Updated (when store distance/unit data is available):
Order Confirmation Page
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization