Skip to content

Fix reset password - #3567

Merged
alexvuong merged 5 commits into
developfrom
fix-reset-password-arg
Jan 8, 2026
Merged

Fix reset password#3567
alexvuong merged 5 commits into
developfrom
fix-reset-password-arg

Conversation

@alexvuong

@alexvuong alexvuong commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Description

Some customers has complained they received 400 error when calling resetPassword api regarding code_verifier

Root cause

  • code_verifier is completely optional when the feature was implemented, but the api has changed and document has not been updated, which results in a mis connection between pwa-kit and SCAP calls.
  • The changes are code_verifier can only be optional if hint and user_id params are defined. hint needs to be 'cross_device`

Solution

  • We updated commerce-react-sdk to use cross_device as default value for hint and user_id parm to resetPassword call (password/action). This is confirmed will fix the issue on 400 error that customers are facing

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alexvuong
alexvuong requested a review from a team as a code owner January 7, 2026 23:28
@cc-prodsec

cc-prodsec commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

bfeister
bfeister previously approved these changes Jan 8, 2026

@bfeister bfeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million for setting this up in a deployment for easier manual validation 🏆

Validated myself, looks great!

Comment thread packages/commerce-sdk-react/src/auth/index.ts Outdated
shethj
shethj previously approved these changes Jan 8, 2026
@alexvuong
alexvuong dismissed stale reviews from shethj and bfeister via f056bb0 January 8, 2026 18:35
shethj
shethj previously approved these changes Jan 8, 2026
bfeister
bfeister previously approved these changes Jan 8, 2026
@alexvuong
alexvuong enabled auto-merge (squash) January 8, 2026 18:38
@alexvuong
alexvuong disabled auto-merge January 8, 2026 18:39
@alexvuong
alexvuong dismissed stale reviews from bfeister and shethj via 2706bb4 January 8, 2026 18:40
@alexvuong
alexvuong enabled auto-merge (squash) January 8, 2026 18:44
@alexvuong
alexvuong merged commit 7faf699 into develop Jan 8, 2026
42 checks passed
@alexvuong
alexvuong deleted the fix-reset-password-arg branch January 8, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants