@W-21481530 Fix alert.js styling to have standard styling on login form and custom outlined styling on subscribe-form. - #3780
Merged
mitesh-patel-crm merged 6 commits intoApr 10, 2026
Conversation
…d not interfere with the default alert styling, such as what was used on the login form.
|
Git2Gus App is installed but the |
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
hajinsuha1
previously approved these changes
Apr 7, 2026
Contributor
|
Can you add test cases to verify 1) the non-subscription form alerts are reverted to default and 2) the outlined variant is working as expected? |
…yle/variants and error feedback integration test.
hajinsuha1
previously approved these changes
Apr 9, 2026
kzheng-sfdc
previously approved these changes
Apr 9, 2026
…cription-styling Signed-off-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
mitesh-patel-crm
dismissed stale reviews from kzheng-sfdc and hajinsuha1
via
April 9, 2026 21:40
3b9778c
hajinsuha1
approved these changes
Apr 10, 2026
kzheng-sfdc
approved these changes
Apr 10, 2026
mitesh-patel-crm
enabled auto-merge (squash)
April 10, 2026 16:24
kieran-sf
approved these changes
Apr 10, 2026
mitesh-patel-crm
deleted the
mitesh-patel-crm/w-21481530-fix-toast-description-styling
branch
April 10, 2026 21:56
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix alert.js styling to have standard styling on login form and custom outlined styling on subscribe-form.
Description
The introduction of marketing consent on the subscription form component caused a regression in the global alert styling, which was used by the login form. This fix changes the styling back to the default across the app, while maintaining the custom style on the form.
Types of Changes
How to Test-Drive This PR
ENABLE_CONSENT_WITH_MARKETING_CLOUDFeature Switch in ECOM to enable Marketing Consent and test the styling changes.Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization