Add flag to preserve original user agent in proxies - #3798
Merged
Conversation
|
Git2Gus App is installed but the |
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kieran-sf
marked this pull request as ready for review
April 29, 2026 16:45
bendvc
reviewed
Apr 29, 2026
| @@ -1,3 +1,6 @@ | |||
| ## 3.19.0 (Apr 27, 2026) | |||
| - Keep original User Agent header in proxy requests | |||
Contributor
There was a problem hiding this comment.
Can you reference the PR please and thank you
bendvc
reviewed
Apr 29, 2026
Comment on lines
-886
to
-891
| // Replace some headers with hardwired values | ||
| if (workingHeaders.getHeader(USER_AGENT)) { | ||
| // Mimic the behaviour of CloudFront | ||
| workingHeaders.setHeader(USER_AGENT, 'Amazon CloudFront') | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Does the remote server keep the user agent? is that why we are removing this from the dev server?
is this breaking? bug?
bendvc
reviewed
Apr 29, 2026
| @@ -1,3 +1,6 @@ | |||
| ## 3.19.0 (Apr 27, 2026) | |||
| - Keep original User Agent header in proxy requests | |||
bendvc
previously approved these changes
Apr 29, 2026
o-olaosebikan
previously approved these changes
Apr 29, 2026
o-olaosebikan
approved these changes
Apr 30, 2026
bendvc
approved these changes
Apr 30, 2026
kieran-sf
enabled auto-merge (squash)
April 30, 2026 22:18
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep the original user agent in proxy requests
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization