Fix MRT Data Store env var names in generated config and README - #3823
Merged
Conversation
The generator templates and the retail-react-app README referenced PWAKIT_MRT_DATA_STORE_DEFAULTS and PWAKIT_MRT_DATA_STORE_WARN_ON_MISSING, but @salesforce/mrt-utilities reads the unprefixed MRT_DATA_STORE_DEFAULTS and MRT_DATA_STORE_WARN_ON_MISSING. Also drop the reference to PWAKIT_MRT_DATA_STORE_ALLOW_LOCAL, which is not consumed anywhere. Aligns the docs with the rename called out in the pwa-kit-runtime 3.18.0 changelog so devs copy-pasting from the comments don't end up with env vars that silently do nothing.
|
Git2Gus App is installed but the |
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
bendvc
approved these changes
May 7, 2026
adamraya
added a commit
that referenced
this pull request
May 7, 2026
* Add Node 24 support to extensible app template Update engines in package.json.hbs to include Node 24. This ensures new extensible apps created with pwa-kit-create-app will support Node 24.x (^24.0.0). The npm range already supports npm 11 which ships with Node 24. * Retrigger CI * Re-add cookieDomain to Auth constructor (#3822) * Fix MRT Data Store env var names in generated config and README (#3823) * Fix MRT Data Store env var names in generated config and README The generator templates and the retail-react-app README referenced PWAKIT_MRT_DATA_STORE_DEFAULTS and PWAKIT_MRT_DATA_STORE_WARN_ON_MISSING, but @salesforce/mrt-utilities reads the unprefixed MRT_DATA_STORE_DEFAULTS and MRT_DATA_STORE_WARN_ON_MISSING. Also drop the reference to PWAKIT_MRT_DATA_STORE_ALLOW_LOCAL, which is not consumed anywhere. Aligns the docs with the rename called out in the pwa-kit-runtime 3.18.0 changelog so devs copy-pasting from the comments don't end up with env vars that silently do nothing. * Retrigger CI * Bump versions to 3.18.0-preview.2 - commerce-sdk-react: 5.2.0-preview.1 → 5.2.0-preview.2 - pwa-kit packages: 3.18.0-preview.1 → 3.18.0-preview.2 - Update CHANGELOGs with preview.2 release entries --------- Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
4 tasks
rfding
pushed a commit
to rfding/pwa-kit
that referenced
this pull request
May 15, 2026
- @salesforce/pwa-kit-runtime, pwa-kit-react-sdk, pwa-kit-dev, pwa-kit-create-app: 3.18.0-preview.2 → 3.18.0 - @salesforce/commerce-sdk-react: 5.2.0-preview.2 → 5.2.0 - @salesforce/retail-react-app: 10.0.0-preview.2 → 10.0.0 - lerna.json + root package.json bumped to 3.18.0 - All package-lock.json files refreshed by `npm install` Collapse preview.0/preview.1/preview.2 CHANGELOG headings into the final 3.18.0 / 5.2.0 / 10.0.0 entries, per the release process. Add the preview.2 entries that were not already in the changelogs: - SalesforceCommerceCloud#3821 Node 24 in extensible app template - SalesforceCommerceCloud#3822 Re-add cookieDomain to Auth constructor - SalesforceCommerceCloud#3823 Fix MRT Data Store env var names in generated config and README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PWAKIT_MRT_DATA_STORE_DEFAULTSandPWAKIT_MRT_DATA_STORE_WARN_ON_MISSING, but@salesforce/mrt-utilitiesactually reads the unprefixedMRT_DATA_STORE_DEFAULTSandMRT_DATA_STORE_WARN_ON_MISSING. Renamed in the comments and the README so copy-pasting from generated projects works.PWAKIT_MRT_DATA_STORE_ALLOW_LOCAL, which is not consumed anywhere in this repo or in@salesforce/mrt-utilities.@salesforce/pwa-kit-runtime3.18.0 changelog.Found while validating PWA Kit 3.18.0-preview.1: setting the
PWAKIT_*-prefixed defaults env vars produced no__MRT_DATA_STORE__data because the names didn't match whatmrt-utilities/dist/*/data-store/development.jsreads.Test plan
Run from a freshly generated 3.18 project:
PWAKIT_MRT_DATA_STORE_ENABLED=true \ MRT_DATA_STORE_DEFAULTS='{"custom-global-preferences":{"testFeature":true},"RefArch-custom-site-preferences":{"storeName":"Test Store RefArch"}}' \ npm startview-source:http://localhost:3000/RefArch/includes__MRT_DATA_STORE__under#mobify-datawith the seeded values.PWAKIT_MRT_DATA_STORE_ENABLED, the key is omitted (regression check).