feat: Decouple equalizer_presets_count from equalizer_presets - #423
Conversation
|
Ah I think I rebased and you pushed something at the same time. Note that your profile is not linked in the commits because you probably dont have that email address in the commit in the GitHub profile |
|
From my side it's ready. Tell me if its fine from your side to also merge. |
|
I did not push anything. I was about to push the linting fixes but you were faster than me. I understand now how I could have implemented the input validation, but at the time I could not find a suitable place to put it. As for the warning, I wanted to fix it before making the PR but forgot. Otherwise it looks good to me and still works with my Audeze Maxwell headset. |
Thank you! Was probably misreading something during push. |
Changes made
I decoupled equalizer_presets_count from equalizer_presets, so I could select all profiles on my Audeze Maxwell headset.
The only downsides of this implementation (as I can see right now) are:
--equalizer-presetis open-ended nowThis would also solve #415.
An alternative to "hardcoding" equalizer_presets_count would be to implement dummy presets for Audeze Maxwell and count those like it was done until now.
Checklist