Skip to content

refactor(AsyncObject)!: propagate cancellation error instead of swallowing#8

Merged
soumyamahunt merged 14 commits into
mainfrom
obj-wait-err
Nov 12, 2022
Merged

refactor(AsyncObject)!: propagate cancellation error instead of swallowing#8
soumyamahunt merged 14 commits into
mainfrom
obj-wait-err

Conversation

@soumyamahunt

@soumyamahunt soumyamahunt commented Sep 4, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 99.90% // Head: 99.83% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (3429a36) compared to base (bca8299).
Patch coverage: 99.78% of modified lines in pull request are covered.

❗ Current head 3429a36 differs from pull request most recent head a9cb9bf. Consider uploading reports for the commit a9cb9bf to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   99.90%   99.83%   -0.08%     
==========================================
  Files          13       17       +4     
  Lines        1054     1186     +132     
==========================================
+ Hits         1053     1184     +131     
- Misses          1        2       +1
Impacted Files Coverage Δ
Sources/AsyncObjects/Extensions/Task.swift 100.00% <ø> (ø)
...ncObjects/Continuation/ContinuableCollection.swift 93.33% <93.33%> (ø)
Sources/AsyncObjects/AsyncCountdownEvent.swift 100.00% <100.00%> (ø)
Sources/AsyncObjects/AsyncEvent.swift 100.00% <100.00%> (ø)
Sources/AsyncObjects/AsyncObject.swift 100.00% <100.00%> (ø)
Sources/AsyncObjects/AsyncSemaphore.swift 100.00% <100.00%> (ø)
Sources/AsyncObjects/CancellationSource.swift 100.00% <100.00%> (ø)
...ources/AsyncObjects/Continuation/Continuable.swift 100.00% <100.00%> (ø)
...AsyncObjects/Continuation/GlobalContinuation.swift 100.00% <100.00%> (ø)
...s/AsyncObjects/Continuation/SafeContinuation.swift 98.64% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soumyamahunt

soumyamahunt commented Sep 27, 2022

Copy link
Copy Markdown
Contributor Author

Blocked by CocoaPods/CocoaPods#11558.

@sonarqubecloud

sonarqubecloud Bot commented Nov 12, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

@soumyamahunt soumyamahunt merged commit 9f7f243 into main Nov 12, 2022
@soumyamahunt soumyamahunt deleted the obj-wait-err branch November 12, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@soumyamahunt