feat(table-of-contents): add new TEDI-Ready component #543 - #551

tedi/components/navigation/table-of-contents/table-of-contents.component.ts (1)

94-94: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Apply the required component member ordering consistently.

• tedi/components/navigation/table-of-contents/table-of-contents.component.ts#L94-L94: move translations before the public inputs.
• tedi/components/navigation/table-of-contents/table-of-contents-item/table-of-contents-item.component.ts#L56-L61: move all injected dependencies before the public inputs.

As per path instructions, injected services must precede inputs/signals.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/navigation/table-of-contents/table-of-contents.component.ts`
at line 94, Reorder component members so injected dependencies precede public
inputs and signals: move the translations injection in
tedi/components/navigation/table-of-contents/table-of-contents.component.ts
(lines 94-94) before the public inputs, and move all injected dependencies in
tedi/components/navigation/table-of-contents/table-of-contents-item/table-of-contents-item.component.ts
(lines 56-61) before its public inputs, without changing behavior.

Source: Path instructions

tedi/components/navigation/table-of-contents/table-of-contents-collapsible/table-of-contents-collapsible.component.ts (2)

78-80: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Move injected services to the top of the class.

As per path instructions, component architecture must follow the order: injected services → inputs/signals → outputs → internal signals/computed → lifecycle → public/private methods. Please move these injected services above the input() declarations.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@tedi/components/navigation/table-of-contents/table-of-contents-collapsible/table-of-contents-collapsible.component.ts`
around lines 78 - 80, Reorder the class members in the table-of-contents
collapsible component so the injected services (`dialog`, `overlay`, and
`translations`) appear before all `input()` declarations, followed by the
remaining members in the prescribed architecture order.

Source: Path instructions

---

93-97: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Simplify redundant nullish coalescing logic.

The resolved ?? this.titleLabel() operation treats an explicit null as a fallback trigger. Since both undefined and null will fall back to this.titleLabel(), the explicit undefined check is redundant and can be simplified.

♻️ Proposed refactor

   readonly title = computed(() => {
-    const heading = this.heading();
-    const resolved = heading === undefined ? this.titleLabel() : heading;
-    return resolved ?? this.titleLabel();
+    return this.heading() ?? this.titleLabel();
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@tedi/components/navigation/table-of-contents/table-of-contents-collapsible/table-of-contents-collapsible.component.ts`
around lines 93 - 97, The title computed value redundantly checks for undefined
and then applies nullish fallback. Simplify the logic in the title computed
property so both null and undefined heading values fall back directly to
this.titleLabel(), while preserving non-null heading values unchanged.

tedi/components/navigation/table-of-contents/table-of-contents-collapsible/table-of-contents-collapsible.component.spec.ts (1)

36-40: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff

Mock TediTranslationService and the CDK dialog/overlay. The spec should use a local translation stub instead of the real service, and a dialog/overlay test double instead of opening the sheet into document.body.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@tedi/components/navigation/table-of-contents/table-of-contents-collapsible/table-of-contents-collapsible.component.spec.ts`
around lines 36 - 40, Update the table-of-contents-collapsible test setup in
beforeEach to provide a local TediTranslationService mock and CDK dialog/overlay
test doubles. Replace the real service and document.body-backed sheet behavior
while preserving the existing HostComponent test flow and translation token
configuration.

Source: Path instructions

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

tedi/components/navigation/table-of-contents/table-of-contents.stories.ts (1)

44-156: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Apply the TEDI component convention to this story demo.

Set changeDetection: ChangeDetectionStrategy.OnPush and encapsulation: ViewEncapsulation.None. Rename the toc-sticky-demo selector and BEM block to use the tedi- prefix. Update the template reference at Line 834 when the selector changes.

As per coding guidelines, “All TEDI Angular components must be standalone, use OnPush change detection, use ViewEncapsulation.None, use Angular signals ..., and use the tedi- selector prefix.” As per path instructions, “Style with tedi-prefixed BEM classes.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/navigation/table-of-contents/table-of-contents.stories.ts`
around lines 44 - 156, Update TocStickyDemoComponent to use
ChangeDetectionStrategy.OnPush and ViewEncapsulation.None, adding the required
Angular imports. Rename the toc-sticky-demo selector and all related BEM classes
to use the tedi- prefix, including their styles and every template reference to
the component selector.

Sources: Coding guidelines, Path instructions