[9.x.x][Shader Graph] Fix Window Layout bugs - #1315
Merged
Merged
Conversation
|
It appears that you made a non-draft PR! |
elizabeth-legros
approved these changes
Jul 16, 2020
ghost
approved these changes
Jul 16, 2020
ghost
left a comment
There was a problem hiding this comment.
Seems to work as well as the 10.x.x version. Approving.
Contributor
Author
|
large diff on inspectorview file is just line ending changes, one of felipe's backports had completely re-written the whole file. should be safe, manually tested and everything still works as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Backport #1298
Broken behavior:
Fixed behavior:
Testing status
Manual Tests: What did you do?
manually tested new graph creation and reloading existing graphs to confirm new window layouts persist.
Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Any test projects to go with this to help reviewers?
Comments to reviewers
Notes for the reviewers you have assigned.