Skip to content

[Shadergraph] Updated Blackboard Resizer styles - #1351

Merged
alindmanUnity merged 7 commits into
masterfrom
sg/blackboard-handle-fix
Aug 6, 2020
Merged

[Shadergraph] Updated Blackboard Resizer styles#1351
alindmanUnity merged 7 commits into
masterfrom
sg/blackboard-handle-fix

Conversation

@esmelusina

Copy link
Copy Markdown
Contributor

This change is in conjunction with this one in trunk https://github.cds.internal.unity3d.com/unity/unity/pull/1415, though pushing this now doesn't cause any problems.

I pulled hardcoded styling information for the 'resizer' that the blackboard uses and put them into the default styles so that they can be overridden accordingly. This is the package local override for those settings to prevent UI elements from fighting.

https://fogbugz.unity3d.com/f/cases/1253962/
https://fogbugz.unity3d.com/f/cases/1163697/

Manual testing-- the resize handle no longer blocks the scrollbars.

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

@esmelusina
esmelusina requested review from a user, alindmanUnity and marctem July 21, 2020 04:53
@esmelusina esmelusina self-assigned this Jul 21, 2020
Comment thread com.unity.shadergraph/CHANGELOG.md Outdated
@esmelusina
esmelusina requested a review from alindmanUnity July 21, 2020 23:02
@esmelusina
esmelusina marked this pull request as ready for review July 22, 2020 18:13
@esmelusina
esmelusina requested a review from a team as a code owner July 22, 2020 18:13
Comment thread com.unity.shadergraph/CHANGELOG.md Outdated
@ghost
ghost self-requested a review July 24, 2020 15:38

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resizer section is really hard to grab now. It feels like there's only around 3 pixels high where the mouse can grab it (even though the element is supposedly 6px tall). I think 10px by 10px would work a lot better.
Edit: the problem seems to be when the mouse approaches from the bottom. There's a space where the mouse should be turning into a resizer icon but it doesn't until you get around 3 pixels into the ui element. If you changed it to 10 px high I think this would fix that problem.

@ghost
ghost self-requested a review July 24, 2020 20:55
Corrected changelog mistake.
@esmelusina

Copy link
Copy Markdown
Contributor Author

The resizer section is really hard to grab now. It feels like there's only around 3 pixels high where the mouse can grab it (even though the element is supposedly 6px tall). I think 10px by 10px would work a lot better.
Edit: the problem seems to be when the mouse approaches from the bottom. There's a space where the mouse should be turning into a resizer icon but it doesn't until you get around 3 pixels into the ui element. If you changed it to 10 px high I think this would fix that problem.

This resolves the issue after the trunk PR lands, but doesn't do much without that landing. I messed up or wasn't aware of the PR process in ono so it was a bit delayed.

As per request.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New resizer handle is way easier to click now. Approving.

@alindmanUnity
alindmanUnity merged commit b24f4b3 into master Aug 6, 2020
@alindmanUnity
alindmanUnity deleted the sg/blackboard-handle-fix branch August 6, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants