PBR shader gbuffer ztest - #43
Merged
sebastienlagarde merged 4 commits intoApr 17, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Original PR: https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/6509
Fix the PBR shader ZTest in the GBuffer pass, it was using a property that doesn't exist in the shader.
https://fogbugz.unity3d.com/f/cases/1230818/
Manual Tests: What did you do?
I Created a new PBR shader graph and then created a material from it (tested both create the material from shader and create new material then assign shader workflows).
Then I assigned the material in the scene and verified that the ZTest was correct.