[HDRP] Add support for the recorder / camera bridge in the graphics compositor - #4599
Merged
Merged
Conversation
sebastienlagarde
approved these changes
May 21, 2021
sebastienlagarde
marked this pull request as ready for review
May 21, 2021 08:59
iM0ve
approved these changes
May 24, 2021
iM0ve
left a comment
Contributor
There was a problem hiding this comment.
I also verified using our HDRP FTP project scene.
Before the PR:
- Was possible to record compositor if the source was Game view
- Impossible to record if the source was set Targeted Camera. Errors in the console while trying to record.
After the PR
- Still possible to record Game view
- Now possible to record when using Targeted Camera. Tested with video and image capture
- No visual difference in the output, before vs after PR
movie_002.mp4
adrien-de-tocqueville
approved these changes
May 25, 2021
phocodes
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Previously the output camera of the graphics compositor could not be directly captured by the Recorder, because the camera bridge interface was not implemented.
With this PR the recorder and other external scripts that use the camera bridge can directly capture the compositor’s output (without capturing the game view)
[This was requested by an internal team]
Testing status
I have tested this using the Recorder 3.0.0-pre.1 and by capturing the compositor's output camera:
both with and without a RenderTarget output. In both cases the image was captured correctly.
Comments to reviewers
This looks easy and safe to backport, so I have added the tags.