Properly handle block change acknowledgements in 1.18.2 -> 1.19#4093
Draft
RaphiMC wants to merge 1 commit into
Draft
Properly handle block change acknowledgements in 1.18.2 -> 1.19#4093RaphiMC wants to merge 1 commit into
RaphiMC wants to merge 1 commit into
Conversation
Member
Author
|
Not ready to merge yet. WorldGuard protected regions are no longer working on non bukkit platforms |
|
I think with these changes and commented this line it works smooth and without any problems, tested on bukkit platform. :) |
emile-ross
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recoded block change acknowledgement handling to fix block placement and block breaking lag issues.
Comparison video with 1 second simulated ping: https://upload.raphimc.net/file/0ZtebB8Se2NJrSQN/adx9mAEt2pcj7ytc/idea64_ZBLOxYOdHa.mp4
Left is with my patch and right is without my patch (Both running connected to a 1.8 server over ViaProxy)
I left the bukkit code mostly untouched. Might be worth to consider removing the bukkit code because the protocol level fix is almost perfect and the bukkit code has its own issues (#3643)