Correct lang mappings (1.12.2 -> 1.13)#4810
Open
valaphee wants to merge 2 commits into
Open
Conversation
b88b40e to
2def649
Compare
Contributor
Author
|
JFI I found these placeholder mismatches, we can replace them, at the expense of localization. |
- use levenshtein distance to find the closest matching key
2def649 to
bf3d7c2
Compare
…nd value mismatched
31ba604 to
f03770b
Compare
kennytv
requested changes
Feb 21, 2026
| "commands.setidletimeout.success": null, | ||
| "commands.summon.success": null, | ||
| "commands.summon.failed": null, | ||
| "commands.setblock.success": null, |
Member
There was a problem hiding this comment.
The ones with placeholder mismatches you mentioned should be removed from the file (or in this specific case, like before, they can map to an unrelated key that matches the content)
Contributor
Author
There was a problem hiding this comment.
Didn't really bother with commands (they are still as before just ordered), and preferred contextual accuracy (as like in the mentioned example above strings could be removed if they don't have any relevance anymore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some lang mappings seemed to be wrong.
Prime example was container.inventory, which should be unchanged, but got somehow mapped to key.categories.inventory which does not exist post 1.21.9.
I also used levenshtein distance to find the closest matching keys for the remaining values.
Resolves #4809