Skip to content

Correct lang mappings (1.12.2 -> 1.13)#4810

Open
valaphee wants to merge 2 commits into
ViaVersion:masterfrom
valaphee:mapping-lang
Open

Correct lang mappings (1.12.2 -> 1.13)#4810
valaphee wants to merge 2 commits into
ViaVersion:masterfrom
valaphee:mapping-lang

Conversation

@valaphee

@valaphee valaphee commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Some lang mappings seemed to be wrong.

Prime example was container.inventory, which should be unchanged, but got somehow mapped to key.categories.inventory which does not exist post 1.21.9.

I also used levenshtein distance to find the closest matching keys for the remaining values.

Resolves #4809

@valaphee valaphee force-pushed the mapping-lang branch 2 times, most recently from b88b40e to 2def649 Compare January 25, 2026 20:02
@valaphee

Copy link
Copy Markdown
Contributor Author

JFI I found these placeholder mismatches, we can replace them, at the expense of localization.

selectWorld.deleteWarning: will be lost forever! (A long time!) -> '%s' will be lost forever! (A long time!)
selectServer.deleteWarning: will be lost forever! (A long time!) -> '%s' will be lost forever! (A long time!)
demo.day.6: You have passed your fifth day, use F2 to save a screenshot of your creation -> You have passed your fifth day, use %s to save a screenshot of your creation
commands.summon.success: Object successfully summoned -> Summoned new %s
commands.setblock.success: Block placed -> Changed the block at %s, %s, %s
commands.particle.success: Playing effect %s for %s times -> Displaying particle %s
commands.kick.success: Kicked %s from the game -> Kicked %s: %s
commands.op.failed: Could not op %s -> Nothing changed. The player already is an operator
commands.deop.failed: Could not de-op %s -> Nothing changed. The player is not an operator
commands.ban.success: Banned player %s -> Banned %s: %s
commands.ban.failed: Could not ban player %s -> Nothing changed. The player is already banned
commands.banip.success: Banned IP address %s -> Banned IP %s: %s
commands.save.failed: Saving failed: %s -> Unable to save the game (is there enough disk space?)
commands.whitelist.add.failed: Could not add %s to the whitelist -> Player is already whitelisted
commands.whitelist.remove.failed: Could not remove %s from the whitelist -> Player is not whitelisted
commands.spreadplayers.success.teams: Successfully spread %s team(s) around %s, %s -> Spread %s teams around %s, %s with an average distance of %s blocks apart
commands.worldborder.damage.buffer.success: Set world border damage buffer to %s blocks (from %s blocks) -> Set the world border damage buffer to %s blocks
commands.worldborder.damage.amount.success: Set world border damage amount to %s per block (from %s per block) -> Set the world border damage time to %s seconds
commands.worldborder.warning.time.success: Set world border warning to %s seconds away (from %s seconds) -> Set the world border warning time to %s seconds
commands.worldborder.warning.distance.success: Set world border warning to %s blocks away (from %s blocks) -> Set the world border warning distance to %s blocks

- use levenshtein distance to find the closest matching key
"commands.setidletimeout.success": null,
"commands.summon.success": null,
"commands.summon.failed": null,
"commands.setblock.success": null,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones with placeholder mismatches you mentioned should be removed from the file (or in this specific case, like before, they can map to an unrelated key that matches the content)

@valaphee valaphee Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really bother with commands (they are still as before just ordered), and preferred contextual accuracy (as like in the mentioned example above strings could be removed if they don't have any relevance anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lang mapping tags are wrong

2 participants