Add is_top_level and page_visibility bits - #23
Merged
Conversation
clelland
reviewed
Mar 27, 2025
clelland
reviewed
Mar 27, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 4, 2025
… API This CL introduces a new flag for adding more context information to crash reports sent by the crash reporting API. It also introduces the the first new bit of information we're experimenting with including in this reports: the `is_top_level` flag, discussed in WICG/crash-reporting#20 and WICG/crash-reporting#23. R=alexmos@chromium.org Bug: 400432195 Change-Id: I15ea2c5a5647aaa89ac40b5eb1fcbac258366135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6361482 Reviewed-by: mmenke <mmenke@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1442945}
This was referenced May 7, 2025
Add
is_top_level and visibility_state fields to crash report bodies
mozilla/standards-positions#1225
Closed
Collaborator
Author
is_top_level bitis_top_level and page_visibility bits
clelland
reviewed
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20, and part of #14 (comment).
This needs interest from other browsers, so I'll file a few standards positions issues momentarily, but maybe @clelland can you review this editorially in the meantime?Standards positions issues:
is_top_levelandvisibility_statefields to crash report bodies mozilla/standards-positions#1225