This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Ensure search is an empty string - #2256
Merged
Merged
Conversation
See #2255; if it's an empty value (like null, our default) but not an empty string, this will generate a useless search query.
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
|
Adding a test case. |
rachelbaker
added a commit
that referenced
this pull request
Feb 10, 2016
Ensure search is an empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2255; if it's an empty value (like null, our default) but not an empty string, this will generate a useless search query.
Fixes #2255 for the API, core should be patched too.