This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Change comment author to structured data - #955
Merged
Merged
Conversation
Member
|
Destructured data is easier to use, and more consistent with the rest of the API |
Member
Author
I'm not sure exactly what you mean by "easier to use". There are contexts certainly where destructured data is easier to use; Backbone models are a good example of that (with I don't think there's a clear benefit to destructured data in that context.
More consistent with what exactly? One advantage of having structured data for comment authors is that you can get a user-like object, which means you can share code for things like views. |
rachelbaker
added a commit
that referenced
this pull request
Mar 25, 2015
Change comment author to structured data
Member
|
Merged #955 |
This was referenced Mar 28, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For comments, we currently have destructured author data in the following form:
{ "author": "admin", "author_email": "admin@example.com", "author_url": "" }Why did we switch from structured data (
author: { ... }) to destructured data in the first place? Is anyone opposed to changing that back?Also fixes #893.