Do not copy function annotations when copying expressions#8512
Merged
Conversation
When copying expressions from one function to another, we previously also copied the function-level annotations from the source function to the destination. This is not correct, and caused a bug where the @binaryen.removable.if.unused annotation was copied from an inlined function to its caller, resulting in side effects being dropped. Fix the problem by moving responsibility for copying function annotations from `copyBetweenFunctions to `copyFunctionWithoutAdd`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying expressions from one function to another, we previously also copied the function-level annotations from the source function to the destination. This is not correct, and caused a bug where the @binaryen.removable.if.unused annotation was copied from an inlined function to its caller, resulting in side effects being dropped. Fix the problem by moving responsibility for copying function annotations from
copyBetweenFunctionstocopyFunctionWithoutAdd.Fixes #8509.