Web Manifest: scope url should strip both query and fragment components - #28381
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash cbc0889) Details |
marcoscaceres
force-pushed
the
eng/Web-Manifest-scope-url-should-strip-both-query-and-fragment-components
branch
from
May 14, 2024 01:46
cbc0889 to
9bfd123
Compare
Collaborator
|
EWS run on current version of this PR (hash 9bfd123) Details |
marcoscaceres
marked this pull request as ready for review
May 14, 2024 06:24
beidson
approved these changes
May 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=273989 rdar://127863839 Reviewed by Brady Eidson. Removes the query and fragment components from the scope URL. Part of w3c/manifest#1122 * Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp: (WebCore::ApplicationManifestParser::parseScope): * Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: (TEST_F): Canonical link: https://commits.webkit.org/278795@main
webkit-commit-queue
force-pushed
the
eng/Web-Manifest-scope-url-should-strip-both-query-and-fragment-components
branch
from
May 15, 2024 04:40
9bfd123 to
a79153b
Compare
Collaborator
|
Committed 278795@main (a79153b): https://commits.webkit.org/278795@main Reviewed commits have been landed. Closing PR #28381 and removing active labels. |
marcoscaceres
deleted the
eng/Web-Manifest-scope-url-should-strip-both-query-and-fragment-components
branch
May 16, 2024 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a79153b
9bfd123