🔨Fix build scripts to handle missing Visual Studio#1626
Conversation
- Fix init.ps1 to check if Visual Studio exists before using vswhere - Add proper null checks for MSBuild path - Make NanoFramework build optional when MSBuild is not available - Show clear warning messages when Visual Studio is not installed This allows the main build to work without Visual Studio installed, while still supporting NanoFramework builds when VS is available.
Code Review✅ Overall AssessmentThis is a well-crafted infrastructure improvement that makes the build system more resilient without introducing any breaking changes. 👍 Positive Changes
📋 Technical ReviewBuild Scripts (build-functions.psm1, init.ps1):
✔️ No Concerns Identified
🎯 RecommendationAPPROVED - This is a straightforward improvement that makes the build system more user-friendly for contributors who may not have Visual Studio installed. The changes are minimal, well-targeted, and maintain backward compatibility. The PR successfully addresses the issue while preserving full functionality for environments with Visual Studio installed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1626 +/- ##
======================================
Coverage 96% 96%
======================================
Files 322 322
Lines 27531 27531
======================================
Hits 26488 26488
Misses 1043 1043 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows the main build to work without Visual Studio installed, while still supporting NanoFramework builds when VS is available.