Skip to content

#493 Added selection state re-evaluation on userSelectAction change#494

Merged
rsimon merged 1 commit into
annotorious:mainfrom
oleksandr-danylchenko:#493-action-change-selection-state
Dec 19, 2024
Merged

#493 Added selection state re-evaluation on userSelectAction change#494
rsimon merged 1 commit into
annotorious:mainfrom
oleksandr-danylchenko:#493-action-change-selection-state

Conversation

@oleksandr-danylchenko

@oleksandr-danylchenko oleksandr-danylchenko commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Issue

See - #493

A user can create an "impossible" state where the userSelectAction is SELECT or NONE, but both the selected is present and the editable is true.**

Changes Made

Added selection state re-evaluation call after updating the currentUserSelectAction. That way, the editing property on the selection will stay up-to-date. Also, the consumers subscribed to the selection state will receive the updated state properly.

@rsimon

rsimon commented Dec 19, 2024

Copy link
Copy Markdown
Member

Good catch - thanks!

@rsimon rsimon merged commit 637a263 into annotorious:main Dec 19, 2024
@oleksandr-danylchenko oleksandr-danylchenko deleted the #493-action-change-selection-state branch December 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants