Skip to content

Fix group/extra bug in initialize_virtualenv#62230

Merged
potiuk merged 1 commit into
apache:mainfrom
tuzonghua:fix-initialize-virtualenv
Apr 2, 2026
Merged

Fix group/extra bug in initialize_virtualenv#62230
potiuk merged 1 commit into
apache:mainfrom
tuzonghua:fix-initialize-virtualenv

Conversation

@tuzonghua

@tuzonghua tuzonghua commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Previously, the initialize_virtualenv script didn't correctly build the uv command to distinguish between --group and --extra. This updates the extra_param to fix that.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg

boring-cyborg Bot commented Feb 20, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@tuzonghua

tuzonghua commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

I automated pulling the dependency-groups keys from the base pyproject.toml file and considered doing the same for the optional-dependencies, but that section is automatically generated by one of the prek scripts, so I didn't want the script to error there. Happy to implement that as well, maybe with a useful error message if it fails.

potiuk
potiuk reviewed Feb 20, 2026
View reviewed changes
Comment thread scripts/tools/initialize_virtualenv.py
@tuzonghua
Fix group/extra bug in initialize_virtualenv
4a284b3 
Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
@tuzonghua tuzonghua force-pushed the fix-initialize-virtualenv branch from 88feacb to 4a284b3 Compare February 23, 2026 14:29
potiuk
potiuk approved these changes Mar 3, 2026
View reviewed changes
Comment thread scripts/tools/initialize_virtualenv.py
Comment thread scripts/tools/initialize_virtualenv.py
@potiuk

potiuk commented Mar 3, 2026

Copy link
Copy Markdown
Member

One last thing to fix.

@potiuk potiuk marked this pull request as draft March 10, 2026 23:14
@potiuk

potiuk commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@tuzonghua This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • ⚠️ Unresolved review comments: This PR has 1 unresolved review thread from maintainers. Please review and resolve all inline review comments before requesting another review. You can resolve a conversation by clicking 'Resolve conversation' on each thread after addressing the feedback. See pull request guidelines.

Note: Your branch is 473 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.

Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk potiuk marked this pull request as ready for review April 2, 2026 16:09
@potiuk potiuk merged commit 6339d09 into apache:main Apr 2, 2026
63 checks passed
@boring-cyborg

boring-cyborg Bot commented Apr 2, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 6339d09 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

potiuk pushed a commit to potiuk/airflow that referenced this pull request Apr 6, 2026
@tuzonghua @potiuk
[v3-2-test] Fix group/extra bug in initialize_virtualenv (apache#62230)
d3e5c05 
Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
(cherry picked from commit 6339d09)

Co-authored-by: Michael Doo <tuzonghua@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 6, 2026
@potiuk @tuzonghua
[v3-2-test] Fix group/extra bug in initialize_virtualenv (#62230) (#6…
2eaed23 
…4808)

Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
(cherry picked from commit 6339d09)

Co-authored-by: Michael Doo <tuzonghua@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 8, 2026
@potiuk @tuzonghua @vatsrahul1001
[v3-2-test] Fix group/extra bug in initialize_virtualenv (#62230) (#6…
17a14b1 
…4808)

Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
(cherry picked from commit 6339d09)

Co-authored-by: Michael Doo <tuzonghua@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@potiuk @tuzonghua @vatsrahul1001
[v3-2-test] Fix group/extra bug in initialize_virtualenv (#62230) (#6…
3c05843 
…4808)

Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
(cherry picked from commit 6339d09)

Co-authored-by: Michael Doo <tuzonghua@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@potiuk @tuzonghua @vatsrahul1001
[v3-2-test] Fix group/extra bug in initialize_virtualenv (#62230) (#6…
196808b 
…4808)

Previously, the initialize_virtualenv script didn't correctly build the uv command to
distinguish between `--group` and `--extra`. This updates the `extra_param` to fix that.
(cherry picked from commit 6339d09)

Co-authored-by: Michael Doo <tuzonghua@users.noreply.github.com>
@tuzonghua tuzonghua mentioned this pull request Apr 21, 2026
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes
@ashb ashb Awaiting requested review from ashb ashb is a code owner
@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner
@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner
@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@kaxil kaxil Awaiting requested review from kaxil
@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

Assignees

No one assigned

Labels

area:dev-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tuzonghua @potiuk