Proposal tweaks - #1797
Merged
Merged
Conversation
|
|
|
CLA Assistant Lite bot Good! All Contributors have signed the CLA. |
Contributor
Author
|
recheck |
Member
|
Thanks for contribution, and wonder is there any way to auto-check typo for code comment? (like a github action/plugin) |
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
============================================
+ Coverage 66.91% 70.85% +3.93%
+ Complexity 978 976 -2
============================================
Files 446 446
Lines 37781 37781
Branches 5380 5380
============================================
+ Hits 25281 26768 +1487
+ Misses 9776 8291 -1485
+ Partials 2724 2722 -2
Continue to review full report at Codecov.
|
Contributor
Author
|
Yes. That's what my next PR would be based around. https://check-spelling.dev |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Fwiw, that PR is up as #1798 |
javeme
reviewed
Mar 28, 2022
Merged
javeme
approved these changes
Mar 28, 2022
imbajin
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this document isn't a living document, it should be tagged as such.
Otherwise, I'd hope you'd accept some minor tweaks.
I typically provide much simpler fixes across repositories. I've queued that task but don't expect to look into it until long after this PR is resolved.