Skip to content

fix equals and hashcode issue - #1856

Merged
javeme merged 3 commits into
apache:masterfrom
seagle-yuan:checkstyle-hashcode
May 7, 2022
Merged

fix equals and hashcode issue#1856
javeme merged 3 commits into
apache:masterfrom
seagle-yuan:checkstyle-hashcode

Conversation

@seagle-yuan

Copy link
Copy Markdown
Contributor

fix equals and hashcode issue

com.baidu.hugegraph.auth.RolePermission.java
com.baidu.hugegraph.backend.cache.RamCache.java
com.baidu.hugegraph.backend.serializer.BinaryBackendEntry.java
com.baidu.hugegraph.backend.serializer.TextBackendEntry.java
com.baidu.hugegraph.structure.HugeEdgeProperty.java
com.baidu.hugegraph.traversal.optimize.HugeCountStep.java
com.baidu.hugegraph.traversal.optimize.HugeGraphStep.java
com.baidu.hugegraph.traversal.optimize.HugeVertexStep.java

@codecov

codecov Bot commented May 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1856 (3c64576) into master (044a15e) will increase coverage by 4.00%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##             master    #1856      +/-   ##
============================================
+ Coverage     66.96%   70.96%   +4.00%     
+ Complexity      982      980       -2     
============================================
  Files           447      447              
  Lines         38045    38072      +27     
  Branches       5391     5401      +10     
============================================
+ Hits          25476    27018    +1542     
+ Misses        10065     8407    -1658     
- Partials       2504     2647     +143     
Impacted Files Coverage Δ
.../java/com/baidu/hugegraph/auth/RolePermission.java 90.69% <0.00%> (-1.07%) ⬇️
...gegraph/backend/serializer/BinaryBackendEntry.java 77.77% <0.00%> (+5.86%) ⬆️
...hugegraph/backend/serializer/TextBackendEntry.java 82.73% <0.00%> (-0.50%) ⬇️
...du/hugegraph/traversal/optimize/HugeCountStep.java 61.11% <0.00%> (-30.56%) ⬇️
...u/hugegraph/traversal/optimize/HugeVertexStep.java 67.81% <0.00%> (-6.87%) ⬇️
...du/hugegraph/traversal/optimize/HugeGraphStep.java 75.58% <12.50%> (-6.47%) ⬇️
...va/com/baidu/hugegraph/backend/cache/RamCache.java 72.22% <100.00%> (-0.41%) ⬇️
...om/baidu/hugegraph/structure/HugeEdgeProperty.java 68.42% <100.00%> (+1.75%) ⬆️
...va/com/baidu/hugegraph/structure/HugeProperty.java 48.00% <0.00%> (-4.00%) ⬇️
...m/baidu/hugegraph/backend/cache/AbstractCache.java 76.00% <0.00%> (-1.00%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a15e...3c64576. Read the comment docs.

Comment thread hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/RamCache.java Outdated
javeme
javeme previously approved these changes May 4, 2022
@seagle-yuan
seagle-yuan requested a review from javeme May 6, 2022 08:37
@javeme
javeme merged commit c128b4a into apache:master May 7, 2022
@seagle-yuan
seagle-yuan deleted the checkstyle-hashcode branch May 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants