Skip to content

feat(clustertest): add basic MiniCluster module for distributed system - #2615

Merged
VGalaxies merged 51 commits into
apache:masterfrom
HJ-Young:master
Oct 15, 2024
Merged

feat(clustertest): add basic MiniCluster module for distributed system#2615
VGalaxies merged 51 commits into
apache:masterfrom
HJ-Young:master

Conversation

@HJ-Young

@HJ-Young HJ-Young commented Aug 4, 2024 •
edited by imbajin
Loading

Copy link
Copy Markdown
Contributor

Purpose of the PR

subtask of #2593

Refer doc to get the design/details

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin
imbajin requested review from javeme and zyxxoo August 9, 2024 08:41
@imbajin imbajin added the feature New feature label Aug 9, 2024
@imbajin imbajin changed the title feat(it): add basic miniCluster environment feat(it): add basic MiniCluster module for distributed system Aug 9, 2024
@HJ-Young

HJ-Young commented Aug 10, 2024 •
edited by imbajin
Loading

Copy link
Copy Markdown
Contributor Author

doc reference url is here

javeme
javeme reviewed Aug 10, 2024
View reviewed changes
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java Outdated
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java Outdated
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java Outdated
Comment thread ...graph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/config/ClusterConfImpl.java Outdated
Comment thread hugegraph-it/hg-it-dist/pom.xml
zyxxoo
zyxxoo reviewed Aug 14, 2024
View reviewed changes
Comment thread hugegraph-it/hg-it-dist/pom.xml
Comment thread hugegraph-it/hg-it-dist/pom.xml
Comment thread hugegraph-it/hg-it-dist/src/assembly/static/multi/pd/A/conf/application.yml.template
zyxxoo
zyxxoo reviewed Aug 14, 2024
View reviewed changes
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/env/AbstractEnv.java Outdated
Comment thread ...aph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/AbstractNodeWrapper.java Outdated
Comment thread ...aph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/AbstractNodeWrapper.java Outdated
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/BaseNodeWrapper.java Outdated
zyxxoo
zyxxoo reviewed Aug 14, 2024
View reviewed changes
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/BaseNodeWrapper.java Outdated
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/PDNodeWrapper.java Outdated
Comment thread hugegraph-it/hg-it-minicluster/src/main/java/org/apache/hugegraph/it/node/StoreNodeWrapper.java Outdated
javeme
javeme reviewed Aug 17, 2024
View reviewed changes
Comment thread hugegraph-cluster-test/hg-ct-dist/pom.xml Outdated
@codecov

codecov Bot commented Aug 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.21%. Comparing base (29ecc04) to head (e677136).

❗ There is a different number of reports uploaded between BASE (29ecc04) and HEAD (e677136). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (29ecc04) HEAD (e677136)
7 1
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #2615       +/-   ##
============================================
- Coverage     47.76%   1.21%   -46.55%     
+ Complexity      821       8      -813     
============================================
  Files           719     697       -22     
  Lines         58918   56403     -2515     
  Branches       7597    7149      -448     
============================================
- Hits          28141     685    -27456     
- Misses        27953   55667    +27714     
+ Partials       2824      51     -2773

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VGalaxies
VGalaxies reviewed Oct 9, 2024
View reviewed changes

@VGalaxies VGalaxies left a comment •
edited by imbajin
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better avoid hardcoding 127.0.0.1

PS: Also remember to remove useless conf files in dist/static/

@HJ-Young

HJ-Young commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

@Thespica

Thespica commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

@HJ-Young

HJ-Young commented Oct 13, 2024

Copy link
Copy Markdown
Contributor Author

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

Hi, @Thespica . It seems that release jar package has not been updated?

@Thespica

Thespica commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

Cluster-Test CI is blocked by PR, which will fix the edgelabel_type in hugegraph-client

Hi @HJ-Young , this PR is ready, and will be merged soon.

Hi, @Thespica . It seems that release jar package has not been updated?

Yes, it hasn't been released yet.

For testing purpose, you can modify the ci temporarily to install the hugegraph-client that supports father-sub-edge from source(or only do it on your local), then have a test.

imbajin
imbajin reviewed Oct 13, 2024
View reviewed changes
Comment thread ...cluster-test/hugegraph-clustertest-dist/src/assembly/static/server/hugegraph-server.keystore Outdated

@imbajin imbajin Oct 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary binary file?

Comment thread hugegraph-cluster-test/hugegraph-clustertest-dist/src/assembly/static/server/computer.yaml Outdated

@imbajin imbajin Oct 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment thread hugegraph-cluster-test/hugegraph-clustertest-dist/src/assembly/static/server/log4j2.xml Outdated

@imbajin imbajin Oct 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it? Also add a TODO comment to reuse the config files in future

imbajin
imbajin approved these changes Oct 14, 2024
View reviewed changes

@imbajin imbajin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember add basic doc for it later

@VGalaxies
VGalaxies merged commit 1a82d83 into apache:master Oct 15, 2024
@imbajin imbajin added this to the 1.5.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javeme javeme javeme left review comments
@imbajin imbajin imbajin approved these changes
@VGalaxies VGalaxies VGalaxies approved these changes
@zyxxoo zyxxoo zyxxoo left review comments
+1 more reviewer
@shirleyStorage shirleyStorage shirleyStorage left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@HJ-Young HJ-Young

Labels

ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

HugeGraph PD-Store Tasks
Status: Done

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

7 participants

@HJ-Young @Thespica @javeme @zyxxoo @imbajin @VGalaxies @shirleyStorage