Fix serialization tests run failed - #450
Merged
Merged
Conversation
Linary
force-pushed
the
edge-serializer-bug
branch
from
April 11, 2019 06:01
a149833 to
ad39a38
Compare
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
============================================
+ Coverage 70.15% 70.17% +0.01%
- Complexity 3281 3287 +6
============================================
Files 208 208
Lines 16082 16095 +13
Branches 2310 2314 +4
============================================
+ Hits 11282 11294 +12
+ Misses 3547 3546 -1
- Partials 1253 1255 +2
Continue to review full report at Codecov.
|
Linary
force-pushed
the
edge-serializer-bug
branch
4 times, most recently
from
April 12, 2019 10:13
35fb120 to
1a2e84a
Compare
javeme
requested changes
Apr 12, 2019
| } | ||
| Relation relation = (Relation) condition; | ||
| if (relation.key().equals(HugeKeys.LABEL)) { | ||
| if (relation.value() instanceof List) { |
Contributor
There was a problem hiding this comment.
should relation be EQ or IN? how about other relations like NEQ?
| if (relation.value() instanceof List) { | ||
| @SuppressWarnings("unchecked") | ||
| List<Object> labels = (List<Object>) relation.value(); | ||
| labelsList.add(labels); |
Contributor
There was a problem hiding this comment.
prefer define a labelsSet and call labelsSet.addAll(labels)
| labelsList.add(labels); | ||
| } else { | ||
| List<Object> labels = new ArrayList<>(); | ||
| labels.add(relation.value()); |
Contributor
There was a problem hiding this comment.
labelsSet.add(relation.value())
| this.conditions.add(Condition.in(HugeKeys.LABEL, results)); | ||
| } | ||
| } | ||
|
|
Change-Id: Idd14fc15f1ed15193d63d105189b14ae59429691
Linary
force-pushed
the
edge-serializer-bug
branch
from
April 15, 2019 07:10
1a2e84a to
0f4ef51
Compare
javeme
requested changes
Apr 15, 2019
Change-Id: Ie39fbe9d2721ca2dd709ae7c5b5947e75d840f97
javeme
approved these changes
Apr 15, 2019
zhoney
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I25cb4b691ed6401ec749ab3b5152b1796ccca244