Add unit tests for com.baidu.hugegraph.util.StringUtil - #485
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
============================================
+ Coverage 68.99% 69.02% +0.03%
- Complexity 3280 3283 +3
============================================
Files 208 208
Lines 16193 16193
Branches 2334 2334
============================================
+ Hits 11172 11178 +6
+ Misses 3774 3765 -9
- Partials 1247 1250 +3
Continue to review full report at Codecov.
|
Contributor
|
@Braavos96 Thank you very much for your code contribution. Yes it's very useful to improve the tests, |
javeme
requested changes
Apr 26, 2019
javeme
left a comment
Contributor
There was a problem hiding this comment.
Looks great! there are still some comments and please don't forget to sign CLA
Braavos6
force-pushed
the
add-diffblue-tests
branch
from
May 1, 2019 09:29
ab49895 to
cf80faf
Compare
Contributor
Author
|
Hi @javeme, I have amended the test cases to include your comments on it and also signed the CLA. |
javeme
requested changes
May 6, 2019
Contributor
|
@Braavos96 Thank you very much, there are some minor comments to be addressed. |
Braavos6
force-pushed
the
add-diffblue-tests
branch
2 times, most recently
from
May 13, 2019 09:43
0368547 to
b6217e1
Compare
javeme
reviewed
May 14, 2019
javeme
left a comment
Contributor
There was a problem hiding this comment.
Still some comments, thanks very much
Linary
requested changes
May 14, 2019
zhoney
previously requested changes
May 14, 2019
Braavos6
force-pushed
the
add-diffblue-tests
branch
from
May 14, 2019 07:53
b6217e1 to
a1232ff
Compare
javeme
requested changes
May 14, 2019
These tests were written using Diffblue Cover.
Braavos6
force-pushed
the
add-diffblue-tests
branch
from
May 14, 2019 15:37
a1232ff to
84f0ecd
Compare
javeme
approved these changes
May 15, 2019
Linary
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that com.baidu.hugegraph.util.StringUtil is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.