Core, Spark: Fix handling of null binary values when sorting with zorder#10026
Merged
Conversation
5659d29 to
5859b11
Compare
RussellSpitzer
approved these changes
Mar 22, 2024
nastra
reviewed
Mar 25, 2024
nastra
reviewed
Mar 25, 2024
nastra
approved these changes
Mar 25, 2024
nastra
left a comment
Contributor
There was a problem hiding this comment.
LGTM with some minor comments
5859b11 to
f1fbf50
Compare
Contributor
Author
|
Merging, thanks for the reviews @RussellSpitzer @nastra ! |
cccs-br
pushed a commit
to CybercentreCanada/iceberg
that referenced
this pull request
May 6, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10022
Currently we don't handle null binary values correctly when they are part of a zordered column. In terms of ordering they should just be a 0'd out buffer (simllar to strings).