Kafka Connect: Add config for transactional ID prefix#11780
Merged
bryanck merged 1 commit intoMar 14, 2025
Merged
Conversation
Contributor
Author
|
Any feedback for this PR? /cc @bryanck |
Contributor
|
I'll take a look this week, thanks for your patience! |
Contributor
Author
Contributor
Author
|
@bryanck trying to ping once more - it has been quite some time now since you wanted to have a look I would really want to avoid to fork the iceberg connector just to get it working when using ACLs for Kafka transaction ids. |
|
Hey - I am also interested in this - any update? |
bryanck
reviewed
Mar 14, 2025
bcc442d to
27b131d
Compare
bryanck
approved these changes
Mar 14, 2025
Contributor
|
Thanks for the contribution @thjaeckle , and sorry for the delay! |
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Kafka setup where strict ACLs are applied, e.g. based on a certain
PREFIXfor Transactional IDs, it is important to have the prefix configurable.Currently, it is the name of the "Channel" (e.g.
"worker"or"coordinator"for the 2 extending subclasses):iceberg/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java
Lines 57 to 67 in 540d6a6
This PR introduces an optional prefix to add - which by default is empty so that the behaviour is not changed to the current behaviour.