Core: Apply correct metric configs in GenericAppenderFactory#12366

Merged

pvary merged 5 commits into

apache:mainfrom

xxubai:fix-generic-appender-metric-configs

Mar 11, 2025

xxubai commented Feb 21, 2025

Contributor

The DataWriter created using GenericAppenderFactory in the application does not configure metric writing behavior according to the table's properties.

Based on previous modifications, such as FlinkAppenderFactory, this class should also invoke the correct API to configure the relevant properties

github-actions Bot added spark data flink KAFKACONNECT labels

xxubai commented Feb 21, 2025

Contributor Author

The specific cause of the issue can be referenced in apache/amoro#3273

xxubai force-pushed the fix-generic-appender-metric-configs branch 2 times, most recently from 52ed81c to c9dfece Compare

February 21, 2025 12:54

pvary reviewed

View reviewed changes

.palantir/revapi.yml Outdated

xxubai force-pushed the fix-generic-appender-metric-configs branch from c9dfece to d0ac6f4 Compare

February 21, 2025 16:12

github-actions Bot removed the KAFKACONNECT label


          keep previous constructors

00f3e02

xxubai force-pushed the fix-generic-appender-metric-configs branch from d0ac6f4 to 00f3e02 Compare

February 21, 2025 16:21

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java


          update review

e90dad9

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary commented Feb 21, 2025

Contributor

Please add some tests to ensure that the metrics are honored if the table is set

xxubai requested a review from pvary

February 21, 2025 17:35


          add tests

27263c1

xxubai force-pushed the fix-generic-appender-metric-configs branch from 5eeeabd to 27263c1 Compare

February 21, 2025 17:37

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

xxubai requested a review from pvary

February 25, 2025 05:37

xxubai force-pushed the fix-generic-appender-metric-configs branch 2 times, most recently from b68da25 to f0b7763 Compare

February 25, 2025 05:44


          fix review

4a3375a

fix checkstyle

xxubai force-pushed the fix-generic-appender-metric-configs branch from b7123bf to 4a3375a Compare

February 25, 2025 06:27

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated

pvary reviewed

View reviewed changes

data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java Outdated


          update

16a7b3d

xxubai force-pushed the fix-generic-appender-metric-configs branch from 661119b to 16a7b3d Compare

February 27, 2025 03:06

pvary approved these changes

View reviewed changes

xxubai commented Feb 27, 2025

Contributor Author

Thank you so much for the review, @pvary

pvary merged commit f61f971 into apache:main

pvary commented Mar 11, 2025

Contributor

Merged to main.
Thanks for the PR @XBaith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data flink spark