Core: Use InternalData with avro for readers.#12476
Merged
Merged
Conversation
ajantha-bhat
reviewed
Mar 7, 2025
6f1eb95 to
fa60870
Compare
danielcweeks
commented
Mar 7, 2025
rdblue
reviewed
Mar 7, 2025
rdblue
reviewed
Mar 7, 2025
pvary
reviewed
Mar 10, 2025
501033c to
7570f6b
Compare
danielcweeks
commented
Mar 20, 2025
| .build()) { | ||
| metadata = headerReader.getMetadata(); | ||
|
|
||
| if (headerReader instanceof AvroIterable) { |
Contributor
Author
There was a problem hiding this comment.
We can hunt down the metadata usage separately from this PR, but this preserves existing behavior while transitioning to the new InternalData read path.
Contributor
There was a problem hiding this comment.
Yeah, I think this is reasonable because it should flag cases where we are using the metadata to recover the partition spec in tests when running with Parquet or formats that don't support it.
rdblue
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the use of InternalData for metadata reads to
ManifestsListsandAllManifestsTableand uses a common iterable that exposes access to file metadata like Avro previously supported. Implements the new metadata read path for both Avro and Parquet.