Skip to content

Core: Add MetricsReporter for SnapshotManager#12665

Merged
nastra merged 4 commits into
apache:mainfrom
wangyinsheng:add_metrics_reporter_for_snapshot_manager
Apr 1, 2025
Merged

Core: Add MetricsReporter for SnapshotManager#12665
nastra merged 4 commits into
apache:mainfrom
wangyinsheng:add_metrics_reporter_for_snapshot_manager

Conversation

@wangyinsheng

Copy link
Copy Markdown
Contributor

Add MetricsReporter for SnapshotManager

@github-actions github-actions Bot added the core label Mar 27, 2025
@nastra nastra self-requested a review March 28, 2025 06:49
@wangyinsheng

Copy link
Copy Markdown
Contributor Author

@nastra PTAL

Comment thread core/src/main/java/org/apache/iceberg/BaseTable.java
Comment thread core/src/test/java/org/apache/iceberg/TestSnapshotManager.java Outdated
Comment thread core/src/test/java/org/apache/iceberg/TestSnapshotManager.java Outdated
Comment thread core/src/test/java/org/apache/iceberg/TestSnapshotManager.java Outdated

@nastra nastra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the remaining comments have been applied

@wangyinsheng wangyinsheng force-pushed the add_metrics_reporter_for_snapshot_manager branch from f719b72 to 5c799a7 Compare April 1, 2025 13:13
@wangyinsheng

Copy link
Copy Markdown
Contributor Author

@nastra PTAL

@nastra nastra merged commit e1f2cfd into apache:main Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants