GCP: Support multiple storage credential prefixes#12881
Merged
Conversation
4cc79c7 to
7da613e
Compare
7da613e to
1fee03b
Compare
48bc144 to
640ff78
Compare
74a0ca1 to
bbae5b6
Compare
danielcweeks
reviewed
May 1, 2025
danielcweeks
reviewed
May 1, 2025
danielcweeks
reviewed
May 1, 2025
danielcweeks
reviewed
May 1, 2025
| */ | ||
| public static final int GCS_DELETE_BATCH_SIZE_DEFAULT = 50; | ||
|
|
||
| private final Map<String, String> allProperties; |
Contributor
There was a problem hiding this comment.
Do we really need to keep all the properties? The goal was to no copy all properties when we should only need the FileIO specific properties (though it looks like all properties were added to the FileIO as well which is questionable)
Contributor
Author
There was a problem hiding this comment.
this shouldn't be needed anymore once we remove GCPProperties from the constructors of GCSFileIO
danielcweeks
reviewed
May 1, 2025
danielcweeks
reviewed
May 1, 2025
bbae5b6 to
0e762f9
Compare
0e762f9 to
25e7cfa
Compare
25e7cfa to
2958fe4
Compare
Contributor
Author
|
thanks for the review @danielcweeks |
3 tasks
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.