REST Spec: Add row lineage fields#13010
Conversation
8aa98db to
cb66b39
Compare
cb66b39 to
dac9eb4
Compare
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Agree with the change, thanks for taking it up!
l think we'd also want to include a change to surface the first-row-id in the snapshot as well as part of this change.
We need to also bring this up on the dev list since it's a spec change.
RussellSpitzer
left a comment
There was a problem hiding this comment.
I mentioned on the ML as well, is there a way we can autogenerate clients/objects from this and check them against our internal objects/apis? Just to make sure we don't diverge for key classes like this
One thought on this that comes to my mind is (open to other ideas), Open API does supports generating java clients and then for checking we can use reflection to check compare the both i.e internal objects with generated objects. Please let me know your thoughts, happy to prototype it out ! |
|
VOTE for spec change passed : https://lists.apache.org/thread/1q3xkvn2373n3g43qjjhnzj7p0v3d9p9 would request to merge this ! Thank you all for your feedbacks ! |
|
thanks @singhpk234 for the contribution and everyone else who reviewed and voted |
Co-authored-by: Prashant Singh <prashant.singh@snowflake.com>
About the change
includes first_row_id in the DataFile for the rest spec used in scan planning, this information IMHO needs to passed from server to client for reads, as its inferred during planning via inheritance from Manifest and manifest list.
Also adds next_row_id to table metadata and first_row_id to snapshot models for completeness,
cc @amogh-jahagirdar