Spark: use Bulk deletion for manifests when import files to an iceberg table#13620
Merged
Merged
Conversation
…g table Signed-off-by: Hongyue Zhang <hongyue.apache@gmail.com>
Signed-off-by: Hongyue Zhang <hongyue.apache@gmail.com>
amogh-jahagirdar
approved these changes
Jul 22, 2025
amogh-jahagirdar
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dramaticlly!
manirajv06
pushed a commit
to manirajv06/iceberg
that referenced
this pull request
Jul 22, 2025
…berg table (apache#13620) Signed-off-by: Hongyue Zhang <hongyue.apache@gmail.com> Addressed review comments Addressed review comments Addressed review comments Addressed review comments Removed testLargeObjectUsingShortStringWithBigHeader(), left testLargeObject() as is and introduced testShortStringsInVariantPrimitives() to cover the short strings stored with 1 byte and 5 byte headers Removed unnecessary lines Fixed checkstyle warnings Fixed unit test failure Addressed review comments Addressed review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage bulk deletion if IO supports, helpful to speed up the table import with many files.
Existing
TestAddFilesProcedurehave many unit tests cover this code path for both hive and hadoop catalog (hadoop fileIO) in