AWS: exclude logging dependencies from bundle#14225
Conversation
There was a problem hiding this comment.
Thanks @danielcweeks , looks right to me. Tested this out locally too and don't hit any no such method failures from log4j. This feels like a good thing to also get in for 1.10.1 as well.
Also, doesn't look like LICENSE need to be updated but do we also need to update the NOTICE here https://github.com/apache/iceberg/blob/main/aws-bundle/NOTICE#L295 ?
I think there are still a couple classes that are relocated and the notice does say "optionally" so I don't think we need an update here. |
|
I'll go ahead and merge, thanks @danielcweeks and @singhpk234 @huaxingao for reviewing. |
|
Is there any plan to cherry-pick this fix to 1.9 1.10 branch? |
(cherry picked from commit 5c6629e)
(cherry picked from commit 5c6629e)
A recent AWS SDK version update introduced Log4j version that are incompatible with some environments (like Spark 4.x). This results in class conflicts if the bundle jar is resolved before other logging jars.
The bom should not include the logging libraries and the existing exclusions don't cover all of the artifacts. This PR expands the exclusions to remove the conflicting dependencies.