Core: Fix validation of PlanTableScanRequest#14561
Merged
singhpk234 merged 1 commit intoNov 11, 2025
Merged
Conversation
nastra
commented
Nov 11, 2025
| .toString(); | ||
| } | ||
|
|
||
| public static Builder builder() { |
Contributor
Author
There was a problem hiding this comment.
this makes sure that the builder is always created through a static method (and aligns it with the rest of the codebase)
singhpk234
reviewed
Nov 11, 2025
The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the `snapshotId` or the `startSnapshotId`/`endSnapshotId`
228c66b to
bb73543
Compare
singhpk234
approved these changes
Nov 11, 2025
Contributor
|
LGTM, thanks for the change and nice catch @nastra ! |
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Nov 12, 2025
The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the `snapshotId` or the `startSnapshotId`/`endSnapshotId`
nastra
added a commit
that referenced
this pull request
Nov 12, 2025
* Core: Fix validation of PlanTableScanRequest (#14561) The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the `snapshotId` or the `startSnapshotId`/`endSnapshotId` * Core: Fix PlanTableScanResponse validation (#14562) The OpenAPI spec indicates in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L3376-L3384 that a `completed` planning result can have a `planId`
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the `snapshotId` or the `startSnapshotId`/`endSnapshotId`
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the `snapshotId` or the `startSnapshotId`/`endSnapshotId`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI spec says in https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L618-L624 that if no snapshotId is provided, the server can select the latest snapshot in the table's main branch. However, currently the request always requires to set either the
snapshotIdor thestartSnapshotId/endSnapshotId