Skip to content

Spark: ORC vectorized reader to use the delete filter#14746

Merged
pvary merged 2 commits into
apache:mainfrom
pvary:orc_vec_del
Dec 5, 2025
Merged

Spark: ORC vectorized reader to use the delete filter#14746
pvary merged 2 commits into
apache:mainfrom
pvary:orc_vec_del

Conversation

@pvary

@pvary pvary commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Refactored out from #14652

@github-actions github-actions Bot added the spark label Dec 3, 2025
@pvary pvary requested a review from huaxingao December 3, 2025 13:31
expectedRowsAfterDelete.get(i).update(3, true);
}

ORC.ReadBuilder builder = ORC.read(Files.localInput(testFile)).project(PROJECTION_SCHEMA);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builder is not used. readAndValidate creates its own ORC.ReadBuilder

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Removed

@huaxingao huaxingao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pvary for the PR!

@pvary pvary merged commit 4c90831 into apache:main Dec 5, 2025
29 checks passed
@pvary

pvary commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Merged to main.
Thanks for the review @huaxingao!

@pvary pvary deleted the orc_vec_del branch December 5, 2025 18:33
thomaschow pushed a commit to thomaschow/iceberg that referenced this pull request Jan 19, 2026
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants