Flink: Fix equalityFieldColumns always null in IcebergSink#14952
Merged
Conversation
f242d02 to
8205a58
Compare
singhpk234
approved these changes
Jan 2, 2026
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks @Guosmilesmile !
ebyhr
approved these changes
Jan 4, 2026
pvary
reviewed
Jan 5, 2026
|
|
||
| private final Table table; | ||
| private final Set<String> equalityFieldColumns = null; | ||
| private final Set<String> equalityFieldColumns; |
Contributor
There was a problem hiding this comment.
Could we leave a comment that this should only be used for logging, and equalityFieldIds should be used instead?
Contributor
Author
There was a problem hiding this comment.
Yes, have added a comment for it.
pvary
approved these changes
Jan 6, 2026
Contributor
|
Merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
equalityFieldColumnsinIcebergSinkis always null, because although the builder holdsequalityFieldColumnsand converts it toequalityFieldColumnIdsbefore passing it toIcebergSink, the rawequalityFieldColumnslist is only used in log statements. Hence, no issue has surfaced so far.This PR fixes the issue where
equalityFieldColumnsis always null, ensuring that the parameter can be correctly printed in the logs when problems occur.